Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine benchmark suite #203

Merged
merged 3 commits into from
Aug 12, 2022
Merged

Refine benchmark suite #203

merged 3 commits into from
Aug 12, 2022

Conversation

kateinoigakukun
Copy link
Member

We had been running benchmarks for a long time and they were very unstable. And also couldn't find meaningful results.

I changed to perform benchmarks with release configuration, and don't repeat noisy prelude for each benchmark.
Also added several benchmark cases to find our bridging bottlenecks (assignment, call, value conversion, ...)

@github-actions
Copy link

github-actions bot commented Aug 12, 2022

Time Change: +5,243ms (24%) 🚨

Total Time: 20,996ms

Test name Duration Change
Serialization/Write JavaScript string directly 3ms -374ms (14233%) 🏆
Object heap/Increment and decrement RC 7,921ms +3,011ms (38%) 🚨
Serialization/Call JavaScript function directly 3ms +3ms (100%) 🆘
Serialization/Assign JavaScript number directly 5ms +5ms (100%) 🆘
Serialization/Call with JavaScript number directly 8ms +8ms (100%) 🆘
Serialization/Call with JavaScript string directly 5ms +5ms (100%) 🆘
Serialization/JavaScript function call through Wasm import 23ms +23ms (100%) 🆘
Serialization/JavaScript function call through Wasm import with int 20ms +20ms (100%) 🆘
Serialization/JavaScript function call from Swift 626ms +626ms (100%) 🆘
Serialization/Swift Int to JavaScript with assignment 443ms +443ms (100%) 🆘
Serialization/Swift Int to JavaScript with call 2,373ms +2,373ms (100%) 🆘
Serialization/JavaScript Number to Swift Int 679ms +679ms (100%) 🆘
Serialization/Swift String to JavaScript with assignment 503ms +503ms (100%) 🆘
Serialization/Swift String to JavaScript with call 2,502ms +2,502ms (100%) 🆘
Serialization/JavaScript String to Swift String 5,880ms +5,880ms (100%) 🆘
View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 0ms -337ms (0%)
Serialization/Swift Int to JavaScript 0ms -5,070ms (0%)
Serialization/Swift String to JavaScript 0ms -5,059ms (0%)

@kateinoigakukun kateinoigakukun requested a review from a team August 12, 2022 12:22
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great improvements, thank you!

@kateinoigakukun kateinoigakukun merged commit 36c672b into main Aug 12, 2022
@kateinoigakukun kateinoigakukun deleted the katei/refine-benchmark branch August 12, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants