Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warning in JSFunction.swift #182

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Fix deprecation warning in JSFunction.swift #182

merged 1 commit into from
Apr 8, 2022

Conversation

MaxDesiatov
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Time Change: +982ms (10%) ⚠️

Total Time: 9,713ms

Test name Duration Change
Serialization/Write JavaScript string directly 193.25ms -11.25ms (5%) ✅
Serialization/Swift Int to JavaScript 2,882ms +228.75ms (7%) 🔍
Serialization/Swift String to JavaScript 3,365.75ms +628.25ms (18%) ⚠️
ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 192.25ms -5.75ms (2%)
Object heap/Increment and decrement RC 3,079.75ms +142ms (4%)

performance-action

@MaxDesiatov MaxDesiatov marked this pull request as ready for review April 8, 2022 11:41
@MaxDesiatov MaxDesiatov requested a review from a team April 8, 2022 11:41
j-f1
j-f1 approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MaxDesiatov MaxDesiatov merged commit ca19e88 into main Apr 8, 2022
@MaxDesiatov MaxDesiatov deleted the maxd/jsvalue-deprecation branch April 8, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-f1 j-f1 j-f1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDesiatov @j-f1