cleanup and deduce of code and types #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 87.59% 88.87% +1.28%
==========================================
Files 29 24 -5
Lines 3079 1978 -1101
==========================================
- Hits 2697 1758 -939
+ Misses 382 220 -162
Continue to review full report at Codecov.
|
…oring continuous scales into a single, generic struct by that original name
…n InputType, since we notably use Double internally for a continuous scale
…eaks, time to sort out flaws
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I can collapse a lot of the repeated code in here ... merging:
into a single type so that I don't need to require around with type erasure, as well as reducing the amount of replicated code that I created while I worked out what this needs to do and how it can be structured.
Now that I've had more time with it, I think ConvertibleToDouble can "go away" and be replaced with a smart initializer and generic code over either
BinaryFloatingPoint&&Realor some nearby variation of that theme, and another for the case where I want to handle one of the Integer variants usingBinaryInteger