Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tick updates #23

Merged
merged 2 commits into from
May 15, 2022
Merged

tick updates #23

merged 2 commits into from
May 15, 2022

Conversation

heckj
Copy link
Member

@heckj heckj commented May 14, 2022

  • added methods to get default tick values just in terms of the strings
  • updated tick methods to pass through a formatter, if provided - defaulting to nil
  • added methods on Point and Band scales to get lists of strings for their ticks

@heckj heckj self-assigned this May 14, 2022
@codecov
Copy link

codecov bot commented May 14, 2022

Codecov Report

Merging #23 (a3b0196) into main (5a01ca3) will decrease coverage by 0.85%.
The diff coverage is 69.00%.

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   90.63%   89.77%   -0.86%     
==========================================
  Files          28       28              
  Lines        2552     2622      +70     
==========================================
+ Hits         2313     2354      +41     
- Misses        239      268      +29     
Impacted Files Coverage Δ
Sources/SwiftVizScale/DiscreteScale.swift 0.00% <ø> (ø)
Sources/SwiftVizScale/LinearScale.swift 92.95% <ø> (ø)
Sources/SwiftVizScale/ContinuousScale.swift 67.76% <48.07%> (-15.77%) ⬇️
Sources/SwiftVizScale/BandScale.swift 87.61% <75.00%> (-1.18%) ⬇️
Sources/SwiftVizScale/PointScale.swift 85.22% <75.00%> (-1.36%) ⬇️
Sources/SwiftVizScale/NiceValue.swift 94.98% <100.00%> (ø)
...ests/SwiftVizScaleTests/ExternalPackageTests.swift 100.00% <100.00%> (ø)
Tests/SwiftVizScaleTests/LinearScaleTests.swift 87.61% <100.00%> (ø)
Tests/SwiftVizScaleTests/LogScaleTests.swift 86.29% <100.00%> (ø)
Tests/SwiftVizScaleTests/TickTests.swift 86.66% <100.00%> (+4.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a01ca3...a3b0196. Read the comment docs.

@heckj heckj merged commit 4961f9e into main May 15, 2022
@heckj heckj deleted the tickValues branch May 15, 2022 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant