Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticks protocol #22

Merged
merged 9 commits into from
May 12, 2022
Merged

Ticks protocol #22

merged 9 commits into from
May 12, 2022

Conversation

heckj
Copy link
Member

@heckj heckj commented May 12, 2022

  • collapsing TickScale protocol (& default implementations) into ContinuousScale
  • adding DiscreteScale to match for Point and Band scale types
  • added DiscreteScaleType to support CustomStringConvertible conformance
  • added naive (wrong!) default implementation for ticks for discrete scales

@heckj heckj self-assigned this May 12, 2022
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #22 (2f580b2) into main (b2566e8) will increase coverage by 0.03%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   90.60%   90.63%   +0.03%     
==========================================
  Files          27       28       +1     
  Lines        2490     2552      +62     
==========================================
+ Hits         2256     2313      +57     
- Misses        234      239       +5     
Impacted Files Coverage Δ
Sources/SwiftVizScale/AnyContinuousScale.swift 60.49% <ø> (+3.70%) ⬆️
Sources/SwiftVizScale/DiscreteScale.swift 0.00% <0.00%> (ø)
Sources/SwiftVizScale/LinearScale.swift 92.95% <ø> (ø)
Sources/SwiftVizScale/LogScale.swift 86.48% <ø> (ø)
Sources/SwiftVizScale/PowerScale.swift 88.46% <ø> (ø)
Sources/SwiftVizScale/RadialScale.swift 85.48% <ø> (ø)
Sources/SwiftVizScale/PointScale.swift 86.58% <80.00%> (-0.92%) ⬇️
Sources/SwiftVizScale/BandScale.swift 88.78% <83.33%> (-0.69%) ⬇️
Sources/SwiftVizScale/ContinuousScale.swift 83.52% <87.50%> (+5.15%) ⬆️
...s/SwiftVizScaleTests/AnyContinuousScaleTests.swift 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2566e8...2f580b2. Read the comment docs.

@heckj heckj merged commit 548281a into main May 12, 2022
@heckj heckj deleted the ticks-protocol branch May 12, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant