Allow VS Code to recognise files with "sourcekit-lsp" scheme to provide Semantic Functionality through SourceKitLSP #990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
requested changes
Aug 2, 2024
Contributor
adam-fowler
left a comment
adam-fowler
left a comment
There was a problem hiding this comment.
One minor thing about converting between vscode and lsp types
lokesh-tr
force-pushed
the
semantic-functionality-in-macro-expansion-reference-document
branch
from
14bb403 to
866d41d
Compare
… it to SourceKitLSP inorder to provide Semantic Functionality
lokesh-tr
force-pushed
the
semantic-functionality-in-macro-expansion-reference-document
branch
from
866d41d to
32ba557
Compare
lokesh-tr
changed the title
lokesh-tr
added a commit
to lokesh-tr/vscode-swift
that referenced
this pull request
Aug 19, 2024
… it to SourceKitLSP inorder to provide Semantic Functionality (swiftlang#990)
lokesh-tr
added a commit
to lokesh-tr/vscode-swift
that referenced
this pull request
Aug 19, 2024
… it to SourceKitLSP inorder to provide Semantic Functionality (swiftlang#990)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes VS Code to recognise files with scheme "sourcekit-lsp", thereby allowing them to be handled by SourceKitLSP and provide Semantic Functionality. Specifically, This PR enables Semantic Functionality in Macro Expansion Reference Document's Peeked Editors.
Refer to the sourcekit-lsp PR below for more information on what semantic functionality is supported as of now.
Accompanying PR in sourcekit-lsp repository: swiftlang/sourcekit-lsp#1610
Expansion of Swift Macros in Visual Studio Code - Google Summer Of Code 2024
@lokesh-tr @ahoppen @adam-fowler