Add setting for environment variables to send to Swift #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we can send `{}` to `execFile` which messes with stuff.
stevapple
suggested changes
May 13, 2022
| @@ -77,6 +77,12 @@ const configuration = { | |||
| get buildArguments(): string[] { | |||
| return vscode.workspace.getConfiguration("swift").get<string[]>("buildArguments", []); | |||
| }, | |||
| /** Environment variables to set when building */ | |||
| get swiftEnvironmentVariables(): { [key: string]: string } { | |||
There was a problem hiding this comment.
I guess we can extract Object.keys(swiftEnvironmentVariables).length > 0 in to a new computed property?
There was a problem hiding this comment.
Not sure this is totally necessary, I do the same in execFile to make it more obvious why we are setting runtimePath env.
when adding environment vars for swiftExec or execFile we either combine with vars passed in or the current process vars
0xTim
approved these changes
May 13, 2022
src/utilities/utilities.ts
Outdated
| options.env = { ...options.env, ...runtimeEnv }; | ||
| } | ||
| } | ||
| // it options contain environment keys add them to process environment keys |
There was a problem hiding this comment.
Not spelling
Suggested change
| // it options contain environment keys add them to process environment keys | |
| // if options contain environment keys add them to process environment keys |
There was a problem hiding this comment.
This code got deleted so no need to fix comment. It is now setup the same as in execFileStreamOutput
This was referenced May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something like this @stevapple?