Fix timeouts for tests and add a test summary to CI jobs #1828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbastien
added
the
full-test-run
matthewbastien
force-pushed
the
nightly-hang
branch
14 times, most recently
from
f15b937 to
d49b3f7
Compare
matthewbastien
force-pushed
the
nightly-hang
branch
14 times, most recently
from
029e224 to
b9a4a91
Compare
matthewbastien
force-pushed
the
nightly-hang
branch
from
b9a4a91 to
ffaa1d8
Compare
matthewbastien
changed the title
matthewbastien
requested review from
0xTim,
adam-fowler and
award999
as code owners
rbenegal
approved these changes
Sep 12, 2025
Contributor
rbenegal
left a comment
rbenegal
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for this!
Member
Author
|
The Linux (nightly-main - jammy) failure is a known issue unrelated to this PR. Going to merge this now. |
aoberoi
added a commit
to aoberoi/vscode-swift
that referenced
this pull request
Dec 6, 2025
> npm warn deprecated @types/diff@8.0.0: This is a stub types definition. diff provides its own type definitions, so you do not need this installed. Related: swiftlang#1828
plemarquand
pushed a commit
that referenced
this pull request
Dec 8, 2025
* Resolve npm install warning for @types/diff deprecation > npm warn deprecated @types/diff@8.0.0: This is a stub types definition. diff provides its own type definitions, so you do not need this installed. Related: #1828 * Migrates away from unmaintained npm package fantasticon Replaces with @twbs/fantasticon fork, which is maintained. Tested by running `npm run compile-icons` (which is indirectly included in the `postinstall` script too), and then previewing the built font (assets/icons/icon-font.woff) on https://fontdrop.info. The 3 expected glyphs were present at the expected codepoints. This does NOT resolve the npm install warning I initially was pursuring. The transitive dep chain is deep, and @twbs/fantasticon still contains the deprecated version of @npmcli/move-file. > npm warn deprecated @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Timeouts were being disabled in our nightly suits accidentally because
isDebugRunwas being set to true. This PR makes sure thatisDebugRunis always false when running in CI and adjusts timeouts for various setup hooks and tests.Additionally, GitHub Actions supports providing a test summary by writing to the file in the environment variable
GITHUB_STEP_SUMMARY. Our tests will now write a test summary to this file so that we can easily see what failed without having to scroll through the output of each job.Tasks
[ ] Documentation has been updated[ ] Added an entry to CHANGELOG.md if applicable