Skip to content

fix: fix decoding error in self-update (#89) #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2024
Merged

fix: fix decoding error in self-update (#89) #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1815963
fix: fix decoding error in `self-update` (#89)
kkebo Jan 7, 2024
64f8f48
add self-update integration test
patrickfreed Jan 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Sources/SwiftlyCore/HTTPClient+GitHubAPI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ import Foundation

public struct SwiftlyGitHubRelease: Codable {
public let tag: String

enum CodingKeys: String, CodingKey {
case tag = "tag_name"
}
}

extension SwiftlyHTTPClient {
Expand Down
13 changes: 12 additions & 1 deletion Tests/SwiftlyTests/SelfUpdateTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,25 @@ final class SelfUpdateTests: SwiftlyTests {
}
}

/// Verify updating the most up-to-date toolchain has no effect.
func testSelfUpdate() async throws {
try await self.runSelfUpdateTest(latestVersion: Self.newPatchVersion)
try await self.runSelfUpdateTest(latestVersion: Self.newMinorVersion)
try await self.runSelfUpdateTest(latestVersion: Self.newMajorVersion)
}

/// Verify updating the most up-to-date toolchain has no effect.
func testSelfUpdateAlreadyUpToDate() async throws {
try await self.runSelfUpdateTest(latestVersion: String(describing: SwiftlyCore.version), shouldUpdate: false)
}

/// Tests that attempting to self-update using the actual GitHub API works as expected.
func testSelfUpdateIntegration() async throws {
try await self.withTestHome {
let swiftlyURL = Swiftly.currentPlatform.swiftlyBinDir.appendingPathComponent("swiftly", isDirectory: false)
try "old".data(using: .utf8)!.write(to: swiftlyURL)

var update = try self.parseCommand(SelfUpdate.self, ["self-update"])
try await update.run()
}
}
}