Don't install the SL SDK into the user account #486
+32
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the release binary for swiftly it uses the static linux SDK with musl to create a system independent binary. The SDK was being installed by the build-swiftly-release tool into the user's home directory with "swift sdk install" command and it tries to uninstall it afterwards. This can pollute a user's system or remove the SDK if they installed it already. In this approach the SDK is extracted into a scratch directory and that directory is provided to the "swift build" command so that it can find it there.
cmcgee1024
requested review from
etcwilde,
justice-adams-apple and
shahmishal
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the release binary for swiftly it uses the static linux SDK with musl to create a system independent binary. The SDK was being installed by the build-swiftly-release tool into the user's home directory with "swift sdk install" command and it tries to uninstall it afterwards. This can pollute a user's system or remove the SDK if they installed it already.
In this approach the SDK is extracted into a scratch directory and that directory is provided to the "swift build" command so that it can find it there.