Refactor list-available command to support json format #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roulpriya
requested review from
shahmishal,
cmcgee1024,
justice-adams-apple and
etcwilde
as code owners
roulpriya
force-pushed
the
refactor-list-available-command-to-support-json-output
branch
3 times, most recently
from
d996fe5 to
777e46b
Compare
cmcgee1024
reviewed
Jun 17, 2025
Sources/Swiftly/OutputSchema.swift
Outdated
| struct AvailableToolchainInfo: OutputData { | ||
| let version: ToolchainVersion | ||
| let inUse: Bool | ||
| let `default`: Bool |
There was a problem hiding this comment.
thought: I'm not sure how I feel about using language keywords for fields, even though Swift allows us to escape it like this. It feels like it should be used very sparingly since it forces all of the call sites to use the back-ticks, which can look confusing, and noisy.
There was a problem hiding this comment.
Agree with you. I'll rename to isDefault
cmcgee1024
reviewed
Jun 17, 2025
| return "{}" | ||
| let jsonData = try encoder.encode(data) | ||
| guard let result = String(data: jsonData, encoding: .utf8) else { | ||
| throw OutputFormatterError.encodingError("Failed to convert JSON data to string.") |
There was a problem hiding this comment.
suggestion: This message is in relation to converting byte Data to a String using the UTF8 encoding. This could be reworded a bit to something that makes this a bit more clear in the very rare case where it occurs. How about something like "failed to encode JSON data as a string in UTF-8"?
roulpriya
force-pushed
the
refactor-list-available-command-to-support-json-output
branch
from
777e46b to
046d741
Compare
roulpriya
force-pushed
the
refactor-list-available-command-to-support-json-output
branch
from
046d741 to
8424f8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
list-availablecommand to support JSON output format