Add macOS job to pull request workflow #364
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcgee1024
requested review from
shahmishal,
justice-adams-apple and
etcwilde
as code owners
shahmishal
reviewed
May 23, 2025
Comment on lines
+25
to
+38
| macos-tests-selfhosted: | ||
| name: Test (Self Hosted) / macOS Sequoia ARM64 | ||
| runs-on: [self-hosted, macos, sequoia, ARM64] | ||
| strategy: | ||
| fail-fast: false | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| - name: Prepare the action | ||
| run: ./scripts/prep-gh-action.sh --install-swiftly | ||
| - name: Build and Test | ||
| run: swift test | ||
| timeout-minutes: 60 | ||
|
|
There was a problem hiding this comment.
Is there reason for not using the github-workflow yml file here?
There was a problem hiding this comment.
It's mainly so that we can use the .swift-version file to control what toolchain to install and use. For that we need swiftly to be installed so that it can fetch and install the toolchain for us.
For other jobs that verify swiftly installs on a fresh system there needs to be no trace of swift or swiftly in those containers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile and test with macOS Sequoia, and the selected Swift toolchain on
each pull request, and merge to the main branch. Also, check the release
build at the same times. Update the prepare GitHub action script so that
it can install swiftly when requested from macOS.