Skip to content

Release updates #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 7, 2024
Merged

Release updates #102

merged 6 commits into from
May 7, 2024

Conversation

adam-fowler
Copy link
Contributor

No description provided.

@adam-fowler adam-fowler requested a review from patrickfreed May 1, 2024 17:09
patrickfreed
patrickfreed approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@patrickfreed patrickfreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making these updates, all look good to me.

did you try building with Swift 5.10? I don't foresee any issues but figured it'd be good to verify before publishing the binaries.

@patrickfreed
Copy link
Contributor

Oh actually could you also update the test dockerfiles to use 5.10 now that our releases will be built with 5.10?

@adam-fowler
Copy link
Contributor Author

@patrickfreed is everything else ok?

@patrickfreed
Copy link
Contributor

Yeah everything else looks okay, just updating test.dockerfile. test-ubi9.dockerfile, and test-amazonlinux2.dockerfile to use 5.10 and having the test run is all that's left.

@adam-fowler
Copy link
Contributor Author

@swift-server-bot test this please

3 similar comments
@adam-fowler
Copy link
Contributor Author

@swift-server-bot test this please

@adam-fowler
Copy link
Contributor Author

@swift-server-bot test this please

@adam-fowler
Copy link
Contributor Author

@swift-server-bot test this please

@adam-fowler adam-fowler merged commit 7c20b09 into main May 7, 2024
5 of 6 checks passed
@adam-fowler adam-fowler deleted the release-updates branch May 7, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickfreed patrickfreed patrickfreed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adam-fowler @patrickfreed