Skip to content

[Test] Replace REQUIRES: shell with UNSUPPORTED: OS=windows-msvc #86927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ramonasuncion wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Test] Replace REQUIRES: shell with UNSUPPORTED: OS=windows-msvc #86927

ramonasuncion wants to merge 3 commits into from
+68 −76

Conversation

@ramonasuncion
Copy link
Member

@ramonasuncion ramonasuncion commented Feb 1, 2026 •
edited
Loading

Partially address #84407

#86927 fixed:
- test/Index/Store/index_compress.swift
- test/SourceKit/CodeComplete/complete_checkdeps_clangmodule.swift                     
- test/SourceKit/CodeComplete/complete_checkdeps_swiftmodule.swift                     
- test/SourceKit/CodeComplete/complete_checkdeps_notifyupdate.swift                    
- test/SourceKit/CodeComplete/complete_checkdeps_avoid_check.swift
- test/Driver/linker.swift

Some of the test have radar requirements, but are still blocking: Test requires the following unavailable features: shell.

@ramonasuncion
Copy link
Member Author

ramonasuncion commented Feb 1, 2026

@swift-ci please smoke test

@ramonasuncion
Copy link
Member Author

ramonasuncion commented Feb 2, 2026

@swift-ci please smoke test linux platform

@ramonasuncion ramonasuncion changed the title [Test][Index] Replace REQUIRES: shell with UNSUPPORTED: OS=windows-msvc in index_compress [Test][Index] Replace REQUIRES: shell with UNSUPPORTED: OS=windows-msvc Feb 2, 2026
@ramonasuncion
Copy link
Member Author

ramonasuncion commented Feb 2, 2026

@swift-ci please smoke test

@ramonasuncion ramonasuncion changed the title [Test][Index] Replace REQUIRES: shell with UNSUPPORTED: OS=windows-msvc [Test] Replace REQUIRES: shell with UNSUPPORTED: OS=windows-msvc Feb 2, 2026
hnrklssn
hnrklssn reviewed Feb 2, 2026
View reviewed changes
test/SourceKit/CodeComplete/complete_checkdeps_avoid_check.swift Outdated
Comment on lines 16 to 25
Copy link
Member

@hnrklssn hnrklssn Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These env vars will need replacing

Copy link
Member Author

@ramonasuncion ramonasuncion Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡 Got it. I was hesitant since they’re disabled, but it won’t hurt once the tests are fixed.

hnrklssn
hnrklssn reviewed Feb 2, 2026
View reviewed changes
test/SourceKit/CodeComplete/complete_checkdeps_clangmodule.swift Outdated
Copy link
Member

@hnrklssn hnrklssn Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

hnrklssn
hnrklssn reviewed Feb 2, 2026
View reviewed changes
test/SourceKit/CodeComplete/complete_checkdeps_notifyupdate.swift Outdated
Copy link
Member

@hnrklssn hnrklssn Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

hnrklssn
hnrklssn reviewed Feb 2, 2026
View reviewed changes
test/SourceKit/CodeComplete/complete_checkdeps_swiftmodule.swift Outdated
Copy link
Member

@hnrklssn hnrklssn Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@ramonasuncion
Copy link
Member Author

ramonasuncion commented Feb 2, 2026

@swift-ci please smoke test

compnerd
compnerd reviewed Feb 2, 2026
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all of these due to the module cache?

test/Index/Store/index_compress.swift
@@ -1,4 +1,4 @@
// REQUIRES: shell
// UNSUPPORTED: OS=windows-msvc
Copy link
Member

@compnerd compnerd Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unnecessary. The real issue I think is head?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compnerd compnerd compnerd left review comments

@hnrklssn hnrklssn hnrklssn left review comments

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

@artemcm artemcm Awaiting requested review from artemcm artemcm is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ramonasuncion @compnerd @hnrklssn