[TempRValueElimination] Make AllocStackInst.hasUses analysis global #86903
+29
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wihtout this change an alloc_stack instruction that is defined in a different basic block than its use could result in instructions that are not dominated by its operands. In an asserts build this is caught by the SIL verifier, but in a non-asserts build it can crash the compiler. Thanks to Erik Eckstein for the actual implementation of the fix! rdar://168622625 (cherry picked from commit d7ca648)
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test macOS |
eeckstein
approved these changes
Feb 1, 2026
fredriss
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wihtout this change an alloc_stack instruction that is defined in a different basic block than its use could result in instructions that are not dominated by its operands. In an asserts build this is caught by the SIL verifier, but in a non-asserts build it can crash the compiler.
Thanks to Erik Eckstein for the actual implementation of the fix!
rdar://168622625
(cherry picked from commit d7ca648)
Explanation: Fix a crash in IRGen causes by an incorrect SIL analysis
Scope: TempRValueElimination pass
Issues: rdar://168622625
Original PRs: #86902
Risk: changes SIL generation
Testing: regression test
Reviewers: @eeckstein