[CSOptimizer] Also favor existential metatype candidates in paramType isAny fast path #85652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
clackary
force-pushed
the
fix/85020-metatype-resolution
branch
from
31150c4 to
34a211d
Compare
Contributor
Author
|
@swift-ci please test |
xedin
reviewed
Nov 21, 2025
xedin
reviewed
Nov 21, 2025
Overload resolution picks wrong initializer for some metatype arguments swiftlang#85020
clackary
force-pushed
the
fix/85020-metatype-resolution
branch
from
34a211d to
a405fff
Compare
clackary
changed the title
Contributor
Author
|
@swift-ci please test |
xedin
approved these changes
Nov 22, 2025
Contributor
|
Thank you! |
Contributor
|
Let's cherry-pick this to 6.3 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test case and a fix to CSOptimizer, regarding a fast path with
Anyparameters that recently landed (c46f9e4). This change introduced a regression where it would cause(T.Type) -> (Any)disjunctions to outrank(T.Type) -> (Any.Type).Refines the check to also favor existential metatype candidates.
Resolves: #85020
Resolves: rdar://163074598