[cxx-interop] Fix type-level ownership annotations for C++ APIs returning reference to frt #84480
+158
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning reference to frt Type-level ownership annotation `SWIFT_RETURNED_AS_UNRETAINED_BY_DEFAULT` was not suppressing warnings on C++ functions returning references to foreign reference types. The `matchSwiftAttrOnRecordPtr` function only checked for `PointerType`, missing `ReferenceType`. This fix updates `matchSwiftAttrOnRecordPtr` to handle both pointer and reference types, ensuring consistent ownership semantics regardless of whether a function returns `FRT*` or `FRT&`. rdar://161226212
fahadnayyar
force-pushed
the
fnayyar/radar-161226212
branch
from
2c66da5 to
c0a673f
Compare
|
@swift-ci please smoke test |
fahadnayyar
requested review from
zoecarver,
egorzhdan,
Xazax-hun,
j-hui,
susmonteiro,
hnrklssn,
beccadax and
ian-twilightcoder
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type-level ownership annotations (
SWIFT_RETURNED_AS_UNRETAINED_BY_DEFAULT) were not suppressing warning for C++ functions (which are not annotated withSWIFT_RETURNS_(UN)RETAIND) returning references (&) to foreign reference types. The annotation only worked for pointer returns (*), forcing developers to manually annotate every function returning a reference.This PR fixes this problem by changing the logic of
matchSwiftAttrOnRecordPtrto considerReferenceTypealso along withPointerType.This PR also adds comprehensive lit tests for ownership conventions and diagnostics related to C++ functions that return references to foreign reference types. These tests were previously not covered by our lit tests.
rdar://161226212