Add presets for OpenBSD bootstrapping. #83355
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please smoke test. |
Member
Author
|
@swift-ci please test. |
Member
Author
|
@swift-ci please test macOS platform. |
2 similar comments
Member
Author
|
@swift-ci please test macOS platform. |
Member
Author
|
@swift-ci please test macOS platform. |
Member
Author
|
@swift-ci please smoke test. |
Member
Author
|
@swift-ci please smoke test. |
Member
Author
|
@swift-ci please smoke test. |
Member
Author
|
@swift-ci please smoke test. |
OpenBSD requires a minor quirk that differ from the standard bootstrapping presets, namely, that because OpenBSD has a modified LLVM toolchain by default, the build process should use that platform toolchain and not the one just-built by the Swift process. More specifically, Swift will still build against the Swift fork of LLVM, but host binaries will be built with the platform toolchain. This also necessitates using pure bridging instead of the default inline bridging. In my limited testing this has not proven to be problematic, and it will be useful for future documentation updates to embed actual presets for shared use. Finally, we ensure that the destdir for these presets are /usr/local, not /usr, as is conventional for software sourced outside of the platform; these are not critical for bootstrapping but will ensure that less changes will need to be made for creating installable packages.
Member
Author
|
@swift-ci please smoke test. |
Member
Author
|
Okay, this should be good to go; I think I confused myself with some non-clean builds. |
Member
Author
|
@etcwilde since you added the inheriting presets, would you mind reviewing? |
Member
Author
|
Ping. |
Member
Author
|
Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenBSD requires a minor quirk that differ from the standard bootstrapping presets, namely, that because OpenBSD has a modified LLVM toolchain by default, the build process should use that platform toolchain and not the one just-built by the Swift process.
More specifically, Swift will still build against the Swift fork of LLVM, but host binaries will be built with the platform toolchain. This also necessitates using pure bridging instead of the default inline bridging.
In my limited testing this has not proven to be problematic, and it will be useful for future documentation updates to embed actual presets for shared use.
Finally, we ensure that the destdir for these presets are /usr/local, not /usr, as is conventional for software sourced outside of the platform; these are not critical for bootstrapping but will ensure that less changes will need to be made for creating installable packages.