[SILOptimizer]Refactor ObjC dependencies in CSE tests #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves tests that require ObjC into a new file and removes the XFAIL on Linux. Partially resolves SR-216.
Author
|
I also guess its worth asking: I tried to use a #if _runtime(_ObjC) build configuration on Linux but the guarded SIL code still failed. This appears to work OK for Swift files and in the REPL.
|
gribozavr
added a commit
that referenced
this pull request
Dec 31, 2015
[SILOptimizer]Refactor ObjC dependencies in CSE tests
Contributor
|
@ezephir Thank you! Splitting out tests is preferred for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves functionality that requires ObjC interop into a new file and removes the XFAIL on Linux. Partially resolves SR-216.
This change was tested both on Ubuntu 14.04 and OS X 10.10.
Question for the review:
Should tests involving @objc be moved out, even though they pass on Linux? (See the first few tests on line 740 or the first few tests on line 944 as examples of what I mean.
Thank you!