Add Feature: NonescapableAccessorOnTrivial #82380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrick
requested review from
slavapestov,
hborla,
xedin and
DougGregor
as code owners
|
@swift-ci test |
slavapestov
approved these changes
Jun 20, 2025
include/swift/AST/Types.h
Outdated
| @@ -700,6 +700,13 @@ class alignas(1 << TypeAlignInBits) TypeBase | |||
| /// Returns true if this contextual type is (Escapable && !isNoEscape). | |||
| bool mayEscape() { return !isNoEscape() && isEscapable(); } | |||
|
|
|||
| /// Returns true if this contextual type satisfies a conformance to Escapable. | |||
There was a problem hiding this comment.
Looks like this doc comment and the next need s/Escapable/BitwiseCopyable/
lib/AST/FeatureSet.cpp
Outdated
| auto sig = nominal->getGenericSignature(); | ||
| return !var->getInterfaceType()->isEscapable(sig); | ||
| auto sig = dc->getGenericSignatureOfContext(); | ||
| return !var->getInterfaceType()->isEscapable(sig); |
There was a problem hiding this comment.
var->getTypeInContext()->isEscapable() also works and avoids having to fish out sig entirely
lib/AST/FeatureSet.cpp
Outdated
| } | ||
| if (auto dc = var->getDeclContext()) { | ||
| auto sig = dc->getGenericSignatureOfContext(); | ||
| if (!var->getInterfaceType()->isEscapable(sig)) { |
There was a problem hiding this comment.
Same remark here about getInterfaceType() vs getTypeInContext()
atrick
force-pushed
the
nonescapable-accessor-on-trivial
branch
from
ae31edc to
8272a63
Compare
atrick
commented
Jun 20, 2025
|
@swift-ci test |
To guard the new UnsafeMutablePointer.mutableSpan APIs.
This allows older compilers to ignore the new APIs. Otherwise, the type checker
will crash on the synthesized _read accessor for a non-Escapable type:
error: cannot infer lifetime dependence on the '_read' accessor because 'self'
is BitwiseCopyable, specify '@Lifetime(borrow self)'
I don't know why the _read is synthesized in these cases, but apparently it's
always been that way.
Fixes: rdar://153773093 ([nonescapable] add a compiler feature to guard
~Escapable accessors when self is trivial)
atrick
force-pushed
the
nonescapable-accessor-on-trivial
branch
from
8272a63 to
cc357f4
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To guard the new UnsafeMutablePointer.mutableSpan APIs.
This allows older compilers to ignore the new APIs. Otherwise, the type checker
will crash on the synthesized _read accessor for a non-Escapable type:
I don't know why the _read is synthesized in these cases, but apparently it's
always been that way.
Fixes: rdar://153773093 ([nonescapable] add a compiler feature to guard
~Escapable accessors when self is trivial)