[Sema] Scale back CodingKeys hack in TypeChecker::lookupUnqualifiedType
#82237
+27
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype` I previously added this hack to match the logic in `TypeChecker::lookupUnqualified`, but it turns out that can introduce request cycles for cases where `CodingKeys` is used in a generic requirement for one of `Codable`'s potential value witnesses. Scale back the hack such that it's only done when we get an initial empty lookup result, ensuring we maintain source compatibility. Both these lookup hacks should go away once we properly handle CodingKeys synthesis. rdar://153096639
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
xedin
approved these changes
Jun 13, 2025
bnbarham
approved these changes
Jun 13, 2025
|
@swift-ci please test |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I previously added this hack to match the logic in
TypeChecker::lookupUnqualified(#79850), but it turns out that can introduce request cycles for cases whereCodingKeysis used in a generic requirement for one ofCodable's potential value witnesses. Scale back the hack such that it's only done when we get an initial empty lookup result, ensuring we maintain source compatibility. Both these lookup hacks should go away once we properly handle CodingKeys synthesis.rdar://153096639