Skip to content

[DestroyAddrHoisting] Don't destructure NE aggs. #81854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025

Conversation

nate-chandler
Copy link
Contributor

When hoisting destroys of aggregates, an attempt is made to fold the destroys of individual fields into the foregoing instructions. If the aggregate is nonescapable, this transformation is illegal. Fixes a verifier error. While here, also block the transformation for noncopyable aggregates.

rdar://152195094

In preparation to use the function in the implementation.
When hoisting destroys of aggregates, an attempt is made to fold the
destroys of individual fields into the foregoing instructions.  If the
aggregate is nonescapable, this transformation is illegal.

rdar://152195094
When hoisting destroys of aggregates, an attempt is made to fold the
destroys of individual fields into the foregoing instructions.  If the
aggregate is noncopyable, this transformation is illegal.
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nate-chandler nate-chandler marked this pull request as ready for review May 30, 2025 18:32
@nate-chandler nate-chandler requested a review from jckarter as a code owner May 30, 2025 18:32
@nate-chandler nate-chandler merged commit dd75d2e into swiftlang:main May 30, 2025
5 checks passed
@nate-chandler nate-chandler deleted the rdar152195094 branch May 30, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants