Skip to content

Revert "[Dependency Scanning] Update Uses of ModuleDeps::ClangModuleDeps #81243" #81658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qiongsiwu
Copy link
Contributor

This reverts commit 024dbd0, reversing changes made to a08b1cb.

The commit did not solve the fundamental issue we need to handle and is no longer necessary.

rdar://144794793

@qiongsiwu
Copy link
Contributor Author

qiongsiwu commented May 21, 2025

@qiongsiwu
Copy link
Contributor Author

swiftlang/llvm-project#10717
@swift-ci smoke test

@cyndyishida
Copy link
Contributor

Can you update the commit title to say "Revert [Dependency Scanning] Update Uses of ModuleDeps::ClangModuleDeps"
Otherwise, it's harder to tell from a condensed git log what the commit is doing.

@qiongsiwu
Copy link
Contributor Author

swiftlang/llvm-project#10717
@swift-ci smoke test

@qiongsiwu
Copy link
Contributor Author

@qiongsiwu qiongsiwu changed the title Revert "Merge pull request #81243 from qiongsiwu/eng_144794793" Revert "[Dependency Scanning] Update Uses of ModuleDeps::ClangModuleDeps #81243" May 21, 2025
@qiongsiwu
Copy link
Contributor Author

swiftlang/llvm-project#10717
@swift-ci smoke test

@qiongsiwu
Copy link
Contributor Author

@qiongsiwu
Copy link
Contributor Author

The previous test failure should be fixed by #81666.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants