[update-checkout] Gracefully degrade timestamp matching. #81654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when invoking the script with match-timestamp, if the refspec was absent, the find_rev_by_timestamp function would throw an exception and the script would hang forever. Here, it is first checked via `git rev-parse --verify $REFSPEC` that the refspec actually exists in the target repo. If it does not, the refspec is just omitted from the command, giving the latest commit before the currently checked out one.
nate-chandler
requested review from
etcwilde,
justice-adams-apple and
shahmishal
as code owners
etcwilde
approved these changes
May 20, 2025
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macos platform |
hamishknight
added a commit
to hamishknight/swift
that referenced
this pull request
May 22, 2025
…checkout/20250520/1" This reverts commit bbe9f65.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when invoking the script with match-timestamp, if the refspec was absent, the find_rev_by_timestamp function would throw an exception and the script would hang forever.
Here, it is first checked via
git rev-parse --verify $REFSPECthat the refspec actually exists in the target repo. If it does not, the refspec is just omitted from the command, giving the latest commit before the currently checked out one.