-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[build.ps1] Revamp No-asserts toolchain build and packaging #81644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should likely be split out, this has no impact on the build/packaging only in the internals of the script.
886310b
to
3ba15e6
Compare
a224b48
to
899402d
Compare
899402d
to
96b4038
Compare
@compnerd updated based on your review feedback. mind taking another look |
f471a28
to
b8be792
Compare
@compnerd i realized that PinnedToolchainVariant was causing trouble, speciallyt hat it was not fully supported before. so remvoing it and making it clear where we expect asserts and where we do not should address your comments |
# /NC: Do not write file classes | ||
# /NS: Do not write file sizes | ||
# /NP: Do not show progress indicator | ||
&robocopy $HostPlatform.ToolchainInstallRoot $HostPlatform.NoAssertsToolchainInstallRoot /E /XC /XN /XO /NS /NC /NFL /NDL /NJH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invoke-Command
would be better than &
.
@swift-ci please smoke test |
|
@compnerd should be running clean now. mind rerunning the smoke test |
@swift-ci please smoke test |
Co-authored-by: Saleem Abdulrasool <compnerd@compnerd.org>
@swift-ci please smoke test |
This PR allows us to build the
noasserts
variant of the compilers along with theasserts
variant by adding a new commandline argument:-IncludeNoAsserts
. This is in preparation for packaging both in our installer and letting users choose which ones to use.If the new option is not set, the build output should not change from today. if the new option is set compilers are built an extra time with asserts disabled.
Note to reviewers: Reviewing this change one commit at a time should give you a better experience than looking at all changes at once.
Changes:
-Variant
(added in #79313), that was added to allow building one variant at a time.-IncludeNoAsserts
to build a new version of the compiler withLLVM_ENABLE_ASSERTIONS=NO
Build-Compilers
when-IncludeNoAsserts
is setBuild-mimalloc
to batch the tools in no-asserts output directory as wellInvoke-BuildStep