Skip to content

[DNM] OutputSpan prototype (updated) #81637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 63 commits into
base: main
Choose a base branch
from
Draft

[DNM] OutputSpan prototype (updated) #81637

wants to merge 63 commits into from
+1,783 −33

Conversation

glessard
Copy link
Contributor

Prototype for OutputSpan (proposed here, updated from here)

glessard and others added 30 commits April 4, 2025 15:38
@glessard
[stdlib] add OutputSpan
819a978
@glessard
[stdlib] disable some initializers
14d0474 
These initializers cause a crash in OwnershipModelEliminator in the toolchain build, but didn’t in the prototype package.
@glessard
[test] OutputSpan tests
8c116e7
@glessard
[test] abi accounting
5433e53
@glessard
[stdlib] add unsafe annotations for OutputSpan
65663f6
@glessard
[stdlib] rename some methods
625fcae
@glessard
[test] update function names
0f7d677
@glessard
[stdlib] update lifetime annotations for OutputSpan
f56806e
@glessard
[stdlib] add more unsafe annotations for OutputSpan
f33ffd3
@glessard
[stdlib] alignment-checking functions for pointers
98ee668
@glessard
[stdlib] better alignment checks
237848e
@glessard
[stdlib] OutputSpan updates
2ca8ba8
@glessard
[stdlib] add OutputRawSpan
3c529bb
@glessard
[stdlib] more outputspan tweaks
73872a1
@lorentey
[stdlib] OutputSpan: follow our coding conventions for organization o…
e74f7d6 
…f type definitions

https://github.com/swiftlang/swift/blob/main/docs/StandardLibraryProgrammersManual.md#presentation-of-type-definitions
@lorentey
[stdlib] OutputSpan.deinit: Make inlinable
6875ad9
@lorentey
[stdlib] OutputSpan API/implementation improvements
69e1df4
@glessard @lorentey
[stdlib] alignment-checking functions for pointers
e0b9af6 
Co-authored-by: Karoy Lorentey <klorentey@apple.com>
@glessard
[stdlib] better alignment checks
a559a9c
@glessard
[stdlib] OutputSpan updates
10ee830
@glessard
[stdlib] add OutputRawSpan
343ab78
@glessard
[stdlib] more outputspan tweaks
c517b8b
@glessard
[stdlib] more OutputSpan tweaks
cc9cc94
@lorentey @glessard
[stdlib] conventional organization of type definition
4aa6924
@lorentey @glessard
[stdlib] OutputSpan.deinit: Make inlinable
6e780ad
@glessard @lorentey
[stdlib] OutputSpan review suggestions
29f46d8 
Co-authored-by: Karoy Lorentey <klorentey@apple.com>
@glessard
Merge branch 'rdar117099863-OutputSpan' into rdar147780495-OutputSpan
387b884 
# Conflicts:
#	stdlib/public/core/Span/MutableSpan.swift
#	stdlib/public/core/Span/OutputRawSpan.swift
#	stdlib/public/core/Span/OutputSpan.swift
#	stdlib/public/core/Span/Span.swift
#	stdlib/public/core/UnsafePointer.swift
@glessard
[test] more abi accounting
b06955e
@glessard
[test] update OutputSpan tests
3bca10f
@glessard
Merge branch 'snapshot-20250412' into rdar147780495-OutputSpan
2400703
glessard added 27 commits April 17, 2025 18:09
@glessard
Merge branch 'rdar147780495-OutputSpan-karoy' into rdar147780495-Outp…
1cf0414 
…utSpan
@glessard
[stdlib] in-place initializer for InlineArray
9f813b6
@glessard
[test] adjust spellings in OutputSpan tests
1231891
@glessard
[test] in-place InlineArray initialization
b3fb519
@glessard
[stdlib] safe in-place initializer for Array
49383a0
@glessard
[stdlib] safe in-place initializer for String
71e49db
@glessard
[test] failing (crashing) InlineArray tests
8840b5e
@glessard
[test] skip crash test on wasi
b74f4cf
@glessard
[stdlib] OutputSpan doc-comment tweaks
e1ed7ec
@glessard
[stdlib] tweak OutputRawSpan implementation
c7675d3
@glessard
[stdlib] OutputRawSpan doc-comment tweaks
e2ba770
@glessard
[stdlib] remove an unnecessary overload
3013aa6
@glessard
[stdlib] list files for cmake
2acca1c
@glessard
[test] disambiguate InlineArray initializers
17aaa56
@glessard
[stdlib] mark initializers inlinable
f4c4657
@glessard
[test] disable a flaky test configuration
c99d9c5 
See swiftlang#81085
@glessard
[stdlib] remove a tweak
137e966
@glessard
[stdlib] fix OutputSpan.removeLast()
eba0d59 
- It should not return an optional, and trap when empty.
- Also add the multiple-element version of `removeLast()`.
@glessard
Merge branch 'snapshot-20250508' into rdar147780495-OutputSpan
ed8f939
@glessard
[stdlib] Array initializer doc-comments
564f022
@glessard
[stdlib] Array.append(addingCapacity:initializingWith:)
a5378a4
@glessard
[test] exercise non-consuming closure captures
86a8186
@glessard
[stdlib] Output[Raw]Span tweaks
ffd0f89
@glessard
[stdlib] add InlineArray._consume()
71cb1a7
@glessard
[stdlib] deprecate InlineArray._withU[M]BP
dc3e084 
- now that the `span` and `mutableSpan` properties are available
@glessard
[test] improve bridged string substring span test
380af42
@glessard
[test] update spellings in tests
dc6a01a
@glessard
Copy link
Contributor Author

@swift-ci please smoke test

@glessard
Copy link
Contributor Author

@swift-ci please build toolchain

@DougGregor
Copy link
Member

@swift-ci please build toolchain Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etcwilde etcwilde Awaiting requested review from etcwilde etcwilde will be requested when the pull request is marked ready for review etcwilde is a code owner

@compnerd compnerd Awaiting requested review from compnerd compnerd will be requested when the pull request is marked ready for review compnerd is a code owner

@edymtt edymtt Awaiting requested review from edymtt edymtt will be requested when the pull request is marked ready for review edymtt is a code owner

@justice-adams-apple justice-adams-apple Awaiting requested review from justice-adams-apple justice-adams-apple will be requested when the pull request is marked ready for review justice-adams-apple is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glessard @DougGregor @lorentey