[Swiftify] Always remove count parameters when possible #81585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnrklssn
requested review from
Xazax-hun,
zoecarver,
egorzhdan,
j-hui,
fahadnayyar and
susmonteiro
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux |
hnrklssn
force-pushed
the
swiftify-ignore-return-sharing
branch
from
9836453 to
9b3a84a
Compare
|
@swift-ci please smoke test |
hnrklssn
force-pushed
the
swiftify-ignore-return-sharing
branch
from
9b3a84a to
9c9a3d7
Compare
|
@swift-ci please smoke test |
DougGregor
approved these changes
May 22, 2025
|
@swift-ci please smoke test Windows |
hnrklssn
force-pushed
the
swiftify-ignore-return-sharing
branch
from
9c9a3d7 to
375164f
Compare
|
@swift-ci please smoke test |
hnrklssn
force-pushed
the
swiftify-ignore-return-sharing
branch
from
375164f to
2c4f623
Compare
|
@swift-ci please smoke test |
hnrklssn
added a commit
to hnrklssn/swift
that referenced
this pull request
May 24, 2025
We used to not emit bounds checks for things like `__counted_by(4)`, but we do now - likely fixed by swiftlang#81585 These regression tests verify that behaviour. rdar://151038254
Previously we did not remove count parameters if any count parameters were shared between count expressions, or if any count expression contained operations. Buffer sizes were also just checked to be larger than or equal than the given count. We now extract the count from Spans/BufferPointers whenever possible, and store that value in a variable at the start of the function. If multiple parameters share the same count, a bounds check is emitted to make sure that they have the same size. Subspans can be used if one span is larger than necessary. The message in the bounds check is changed so that it includes the expected and actual value, to aid in debugging. This patch also fixes some incorrect indentation, and adds the Whitespace.swift test case to act as a regression test in case the indentation changes, since the other test cases don't use significant whitespace. rdar://151488820 rdar://151511090 rdar://146333006 rdar://147715799
We used to not emit bounds checks for things like `__counted_by(4)`, but we do now - likely fixed by swiftlang#81585 These regression tests verify that behaviour. rdar://151038254
hnrklssn
force-pushed
the
swiftify-ignore-return-sharing
branch
from
2c4f623 to
085553a
Compare
|
@swift-ci please smoke test |
hnrklssn
added a commit
to hnrklssn/swift
that referenced
this pull request
May 29, 2025
) Previously we did not remove count parameters if any count parameters were shared between count expressions, or if any count expression contained operations. Buffer sizes were also just checked to be larger than or equal than the given count. We now extract the count from Spans/BufferPointers whenever possible, and store that value in a variable at the start of the function. If multiple parameters share the same count, a bounds check is emitted to make sure that they have the same size. Subspans can be used if one span is larger than necessary. The message in the bounds check is changed so that it includes the expected and actual value, to aid in debugging. This patch also fixes some incorrect indentation, and adds the Whitespace.swift test case to act as a regression test in case the indentation changes, since the other test cases don't use significant whitespace. rdar://151488820 rdar://151511090 rdar://146333006 rdar://147715799 (cherry picked from commit f5fa481)
hnrklssn
added a commit
to hnrklssn/swift
that referenced
this pull request
May 29, 2025
) Previously we did not remove count parameters if any count parameters were shared between count expressions, or if any count expression contained operations. Buffer sizes were also just checked to be larger than or equal than the given count. We now extract the count from Spans/BufferPointers whenever possible, and store that value in a variable at the start of the function. If multiple parameters share the same count, a bounds check is emitted to make sure that they have the same size. Subspans can be used if one span is larger than necessary. The message in the bounds check is changed so that it includes the expected and actual value, to aid in debugging. This patch also fixes some incorrect indentation, and adds the Whitespace.swift test case to act as a regression test in case the indentation changes, since the other test cases don't use significant whitespace. rdar://151488820 rdar://151511090 rdar://146333006 rdar://147715799 (cherry picked from commit f5fa481)
hnrklssn
added a commit
to hnrklssn/swift
that referenced
this pull request
May 31, 2025
) Previously we did not remove count parameters if any count parameters were shared between count expressions, or if any count expression contained operations. Buffer sizes were also just checked to be larger than or equal than the given count. We now extract the count from Spans/BufferPointers whenever possible, and store that value in a variable at the start of the function. If multiple parameters share the same count, a bounds check is emitted to make sure that they have the same size. Subspans can be used if one span is larger than necessary. The message in the bounds check is changed so that it includes the expected and actual value, to aid in debugging. This patch also fixes some incorrect indentation, and adds the Whitespace.swift test case to act as a regression test in case the indentation changes, since the other test cases don't use significant whitespace. rdar://151488820 rdar://151511090 rdar://146333006 rdar://147715799 (cherry picked from commit f5fa481)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we did not remove count parameters if any count parameters were shared between count expressions, or if any count expression contained operations. Buffer sizes were also just checked to be larger than or equal than the given count.
We now extract the count from Spans/BufferPointers whenever possible, and store that value in a variable at the start of the function. If multiple parameters share the same count, a bounds check is emitted to make sure that they have the same size. Subspans can be used if one span is larger than necessary.
The message in the bounds check is changed so that it includes the expected and actual value, to aid in debugging.
This patch also fixes some incorrect indentation, and adds the Whitespace.swift test case to act as a regression test in case the indentation changes, since the other test cases don't use significant whitespace.
rdar://151488820
rdar://151511090
rdar://146333006
rdar://147715799