Skip to content

[6.2] Sema: Fix another -require-explicit-availability regression #80614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

[6.2] Sema: Fix another -require-explicit-availability regression #80614

merged 1 commit into from
Apr 8, 2025

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented Apr 7, 2025 •
edited
Loading

  • Explanation: Extensions that extend non-public types should never be required to have explicit availability, even if they declare conformances to public protocols.
  • Scope: Projects with -require-explicit-availability enabled.
  • Issue/Radar: rdar://148697770
  • Original PR: Sema: Fix another -require-explicit-availability regression #80613
  • Risk: Low. This change just skips more declarations during explicit availability checking.
  • Testing: New compiler test cases.
  • Reviewer: @xymus

@tshortli
Sema: Fix another -require-explicit-availability regression.
3f82559 
Extensions that extend non-public types should never be required to have
explicit availability, even if they declare conformances to public protocols.

Resolves rdar://148697770.
@tshortli tshortli requested a review from a team as a code owner April 7, 2025 21:59
@tshortli
Copy link
Contributor Author

tshortli commented Apr 7, 2025

@swift-ci please test

@tshortli tshortli enabled auto-merge April 7, 2025 22:00
@tshortli tshortli merged commit 9234638 into swiftlang:release/6.2 Apr 8, 2025
5 checks passed
@tshortli tshortli deleted the require-explicit-availability-conformances-6.2 branch April 8, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tshortli @nkcsgexi