Skip to content

Fix two bugs in alloc_stack simplification #80506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025

Conversation

eeckstein
Copy link
Contributor

  • Bail if the address of the allocated existential escapes.
  • Fix AllocStackInst.isLexical: If wrongly returned false.

fixes a miscompile
rdar://148253142

@eeckstein eeckstein requested a review from jckarter as a code owner April 3, 2025 19:50
@eeckstein eeckstein requested a review from aschwaighofer April 3, 2025 19:51
@eeckstein
Copy link
Contributor Author

@swift-ci test

…escapes

This is not a problem if the alloc_stack already contains the opened existential.
Fixes a miscompile
rdar://148253142
If wrongly returned false.
@eeckstein eeckstein force-pushed the fix-simplify-alloc-stack branch from 139b80d to f495597 Compare April 3, 2025 21:05
@eeckstein
Copy link
Contributor Author

@swift-ci test

@eeckstein eeckstein merged commit 253f730 into swiftlang:main Apr 4, 2025
5 checks passed
@eeckstein eeckstein deleted the fix-simplify-alloc-stack branch April 4, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant