Sema: Fix handling of getter typed throws in witness matching #80445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
requested review from
AnthonyLatsis,
hborla and
xedin
as code owners
…erts are enabled Move this away from the compile-time NDEBUG flag.
Witness matching didn't handle the case where either the requirement or the witness is a property with a throwing getter, and the thrown error type contains a type parameter. We must open the thrown error types first, replacing type parameters with type variables, for the matching to work. Associated type inference needs a similar fix. I'll land a combined test case for both once I fix that. Fixes swiftlang#80288. Fixes rdar://problem/147874955.
We must replace type parameters with archetypes in the thrown error type of the witness. The requirement type remains an interface type.
slavapestov
force-pushed
the
fix-issue-80288
branch
from
f73616a to
b26c599
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes witness matching to handle the case where either the requirement or the witness is a property with a throwing getter, and the thrown error type contains a type parameter. There is a similar fix to associated type inference as well. The test case exercises both code paths.
Fixes #80288.
Fixes rdar://problem/147874955.