utils: Update default Android SDKs in build.ps1 #79944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke tests |
hjyamauchi
reviewed
Mar 12, 2025
utils/build.ps1
Outdated
| # Enable all android SDKs by default. | ||
| $AndroidSDKs = @("aarch64","armv7","i686","x86_64") | ||
| # By default enable Android SDKs that we can run executable tests for. | ||
| $AndroidSDKs = switch ($BuildArchName) { |
There was a problem hiding this comment.
This looks like we build the ARM64 Android SDK on the ARM64 windows build? We currently build Android only on the X64 windows build, right? Should it be "if AMD64 then aarch64"?
There was a problem hiding this comment.
Yes agree, as long as execution tests aren't ready, this is a viable option.
weliveindetail
force-pushed
the
windrd-update-default-sdks
branch
from
3084ad2 to
ef3e100
Compare
|
@swift-ci please smoke test |
weliveindetail
force-pushed
the
windrd-update-default-sdks
branch
from
ef3e100 to
6795b39
Compare
|
@swift-ci please smoke test |
|
@hjyamauchi Do you think I can land this? |
hjyamauchi
approved these changes
Mar 13, 2025
|
Yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building all the Android SDKs might not be the ideal default, since it takes a lot of time. We might want to focus on the one we can test best. In the future we want to run executable tests for the Swift runtime on Android and the emulator only works for the native architecture. It might be a better default to build that one, because we will have the best options for testing.