Add a couple of regression tests #79910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
slavapestov
commented
Mar 11, 2025
| } | ||
|
|
||
| func foo1(x: (x: Int, y: Int)?, y: (Int, Int)) -> G<(x: Int, y: Int)> { | ||
| let g = G(t: x ?? y) |
There was a problem hiding this comment.
This was the specific case that regressed with the deep equality change, but if you look at the rest of the file you'll see the general behavior with this sort of thing is quite inconsistent...
|
@swift-ci Please test |
xedin
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR testing of #78958 failed to build
Foundationandswift-docc, while validation tests passed. I haven't been able to resolve these two issues yet, but to make a tiny bit of progress, let's add the two reductions to the test suite.