[embedded] Allow string-interpolating fatalError in Embedded Swift #79581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubamracek
requested review from
MaxDesiatov,
phausler,
rauhul,
eeckstein,
tshortli and
dschaefer2
phausler
approved these changes
Feb 24, 2025
|
@swift-ci please test |
|
@swift-ci please test windows platform |
|
@swift-ci test windows |
MaxDesiatov
approved these changes
Feb 25, 2025
kubamracek
force-pushed
the
embedded-fatalerror-stringinterp
branch
from
0e5a6c4 to
01d7e23
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
fatalErroraccept String and string interpolations in Embedded Swift (previously we only accepted StaticString). Given that the String type is nowadays available in Embedded Swift, there's no reason to keep this divergence in the fatalError API between regular Swift and Embedded Swift.Left TODOs:
TODOs are addressed in #79698.
rdar://138205827