Skip to content

[IRGen] Expose an -Xfrontend flag to disable the LLVM MergeFunctions pass #79546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kubamracek
Copy link
Contributor

@kubamracek kubamracek commented Feb 21, 2025

Motivation is to have a readily available toggle when investigating miscompiles that could be related to function merging.

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@aschwaighofer
Copy link
Contributor

You probably also want to disable the Swift specific merge functions pass in this file?

MPM.addPass(SwiftMergeFunctionsPass(schema.isEnabled(), key));

@kubamracek kubamracek force-pushed the expose-flag-to-disable-merge-functions branch from e2c4e57 to 119d6e2 Compare February 24, 2025 17:05
@kubamracek
Copy link
Contributor Author

@aschwaighofer good point, updated

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@aschwaighofer
Copy link
Contributor

We will also need this for another LLVM PR

@aschwaighofer aschwaighofer merged commit 11922d2 into swiftlang:main Feb 26, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants