[build-script] Add an option to force the linker used. #79329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have been doing this using extra-cmake-args/etc... just feels better to have an actual option to do this. Just did this quickly while waiting for my Linux build to finish that uses extra-cmake-args to set the linker.
|
@swift-ci smoke test |
etcwilde
reviewed
Feb 12, 2025
| @@ -644,6 +644,12 @@ def create_argument_parser(): | |||
| '`bootstrapping-with-hostlibs`, `crosscompile`, and ' | |||
| '`crosscompile-with-hostlibs`') | |||
|
|
|||
| option('--use-linker', store('use_linker'), | |||
| choices=['gold', 'lld'], | |||
There was a problem hiding this comment.
Newer versions of the GNU bfd linker works on newer platforms now too and IIRC gold is going away so I don't think we should block using it anymore.
There was a problem hiding this comment.
My understanding is that bfd doesn't have a specific name... so people will just get it by not setting the flag.
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
etcwilde
approved these changes
Feb 14, 2025
|
@swift-ci test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been doing this using extra-cmake-args/etc... just feels better to have an actual option to do this.
Just did this quickly while waiting for my Linux build to finish that uses extra-cmake-args to set the linker.