Skip to content

[6.1] Revert https://github.com/swiftlang/swift/pull/77550 #78519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented Jan 9, 2025

  • Explanation: Reverts AST: Print opaque result types correctly in swiftinterfaces #77550 because that fix exposed a different existing bug in opaque type result printing where generic archetypes are not consistently resugared on stable addresses, yielding unparsable swiftinterfaces. While the swiftinterface files affected by the issue were actually incorrect both with and without the fix that is being reverted, returning to the status quo of incorrect but parsable output is the safest option for release/6.1.
  • Scope: Libraries with functions that return the opaque result type of a different function within a generic context.
  • Issue/Radar: rdar://142571577
  • Original PR: N/A (this issue will either be reverted or fixed separately on main).
  • Risk: Low, reverts a discretionary compiler fix.
  • Testing: Existing test cases.
  • Reviewer: @bnbarham

@tshortli tshortli requested a review from a team as a code owner January 9, 2025 16:55
@tshortli
Copy link
Contributor Author

tshortli commented Jan 9, 2025

@swift-ci please test

@tshortli tshortli enabled auto-merge January 9, 2025 17:21
@tshortli tshortli merged commit b9e1fdb into swiftlang:release/6.1 Jan 9, 2025
5 checks passed
@tshortli tshortli deleted the revert-77550-6.1 branch January 9, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants