[SourceKit] Add mechanism to load plugins for request handling into SourceKit #78421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
…ourceKit This allows us to load plugins into the sourcekitd service to handle requests (currently only used for code completion). This allows us to implement parts of sourcekitd in Swift and outside of the compiler repository, making it easier to iterated on them because the compiler doesn’t need to be rebuilt.
ahoppen
force-pushed
the
add-sourcekit-plugin
branch
from
3235d7a to
6d0463a
Compare
ahoppen
requested review from
DougGregor,
hborla,
slavapestov and
xedin
as code owners
ahoppen
force-pushed
the
add-sourcekit-plugin
branch
from
fc7588b to
aeac681
Compare
ahoppen
force-pushed
the
add-sourcekit-plugin
branch
from
7f9d3c9 to
425d318
Compare
ahoppen
force-pushed
the
add-sourcekit-plugin
branch
from
425d318 to
c0ad0b6
Compare
|
@swift-ci Please build toolchain |
|
@swift-ci Please build toolchain Linux |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
rintaro
approved these changes
Jan 14, 2025
rintaro
reviewed
Jan 14, 2025
| /// may be more expensive to compute. | ||
| typedef void *swiftide_completion_item_t; | ||
|
|
||
| typedef enum { |
There was a problem hiding this comment.
Not a blocker, but this file should also get changes in swiftlang/sourcekit-lsp@16f897a#diff-39e84eb3460d8f1ea3f90414efa55ebfabe28d7a69b09a1cfdc3b3de7946f459
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to load plugins into the sourcekitd service to handle requests (currently only used for code completion). This allows us to implement parts of sourcekitd in Swift and outside of the compiler repository, making it easier to iterated on them because the compiler doesn’t need to be rebuilt.
swiftlang/sourcekit-lsp#1906 implements the SourceKit plugin for code completion.