[NFC] mark_dependence handling for coroutines and accessors. #77695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isScopeEndingUse is not the same as endsLifetime.
This allows emitting mark_dependence [unresolved] in some cases even if the diagnostics can't currently handle them.
During SIL parsing, allow `@``lifetime(borrow <argNum>)` on trivial arguments.
Mark unresolved mark_depends as nonescaping so they don't leak into the optimizer pipeline.
atrick
requested review from
eeckstein,
hborla,
jckarter,
slavapestov and
xedin
as code owners
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for lifetime dependent coroutines and accessors.
Includes a minor fix to BeginApply that I missed in the previous PR.
Add flexibility to mark_dependence diagnostics. This allows SILGen to emit mark_dependence [unresolved] in more places.
These changes are covered by unit tests on the branch that they were pulled from.