Frontend: Remove -disable-print-package-name-for-non-package-interface #77425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unsound to expose `package` declarations in textual interfaces without a package identity for them to belong to so we should not offer this flag. Resolves rdar://139361524.
tshortli
requested review from
hborla,
slavapestov,
xedin and
artemcm
as code owners
|
@swift-ci please smoke test |
artemcm
approved these changes
Nov 6, 2024
elsh
approved these changes
Nov 6, 2024
|
Please remove the flag from test/Sema/package_enums_treat_exhaustive.swift |
I think it is in the PR - am I missing it somewhere? |
tshortli
deleted the
remove-disable-print-package-name-for-non-package-interface
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unsound to expose
packagedeclarations in textual interfaces without a package identity for them to belong to so we should not offer this flag.Resolves rdar://139361524.