Improved Error._domain calculation #77369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
Here is test that will check correctness of my changes: Error.swift |
|
@swift-ci please smoke test |
|
Swift Test Windows Platform failed on one sourcekit-lsp test. Seems like flaky-failure to me. @jmschonfeld could you please rerun tests for Windows platform? Thanks in advance! |
|
@swift-ci please smoke test Windows platform |
jmschonfeld
approved these changes
Nov 6, 2024
glessard
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized
Error._domaincalculation.String(reflecting:)forAny.Typeobjects eventually calls_type(:qualified:). ButString(reflecting:)call has overhead because ofas?checks.All details are listed in issue.
Resolves swiftlang/swift-foundation#1031