[cxx-interop] Use the locations imported from C++ #77323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
zoecarver,
hyp,
egorzhdan,
hborla,
slavapestov and
xedin
as code owners
Xazax-hun
commented
Oct 31, 2024
Xazax-hun
force-pushed
the
gaborh/use-imported-locs
branch
from
72d1ebb to
544457b
Compare
A recent PR (#77204) started to import C++ source locations into Swift. This PR flips a switch so these locations are actually used more widely. Now some of the diagnostic locations are changed, but they generally improved the quality of the diagnostics, pointing out conformances imported from Obj-C code right when they are declared.
Xazax-hun
force-pushed
the
gaborh/use-imported-locs
branch
from
544457b to
6d24c52
Compare
Xazax-hun
requested review from
ahoppen,
bnbarham,
hamishknight,
rintaro and
adrian-prantl
as code owners
|
@swift-ci please smoke test |
egorzhdan
approved these changes
Nov 4, 2024
|
@swift-ci please smoke test |
|
Please test with following pull request: @swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent PR (#77204) started to import C++ source locations into Swift. This PR flips a switch so these locations are actually used more widely.