Skip to content

[Swift 6.0.x] Default Linux toolchain linker to gold #77209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

etcwilde
Copy link
Member

The BFD linker on most of the Linux box is unable to link Swift objects. Currently the Swift driver hard-codes forcing the default linker to gold, but we want to support configuring this, so we need build-script to force it at the clang level instead.

Cherry-Picks:
d63152f
7596d00
8262552

This is needed to land swiftlang/swift-driver#1595.

@etcwilde etcwilde requested a review from a team as a code owner October 24, 2024 20:41
@etcwilde etcwilde force-pushed the ewilde/release-60-all-that-glitters-is-gold branch from bab6e44 to 6c30a5e Compare October 24, 2024 20:45
The BFD linker on most of the Linux box is unable to link Swift objects.
Currently the Swift driver hard-codes forcing the default linker to
gold, but we want to support configuring this, so we need build-script
to force it at the clang level instead.

Cherry-Picks:
  d63152f
  7596d00
  8262552
@etcwilde etcwilde force-pushed the ewilde/release-60-all-that-glitters-is-gold branch from 6c30a5e to 0a9b1fd Compare October 24, 2024 20:51
@etcwilde
Copy link
Member Author

@swift-ci please test

@etcwilde
Copy link
Member Author

@swift-ci Please smoke test Linux platform

@etcwilde
Copy link
Member Author

@swift-ci Please Build Toolchain Linux Platform

@etcwilde
Copy link
Member Author

etcwilde commented Nov 4, 2024

I'd already tried to cherry-pick it here: #73760
Closing now that that one has landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants