[NFC] PredictableMemOpts: refactor to allow extension #76996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fully encapsulate ownership fixup so we can extend it.
PredictableMemOpt only runs with OSSA. The recent refactoring did not preserve non-OSSA conditions because it adds complexity. This commit just makes it official. In the near future, this pass will be replaced by an OSSA-only pass anyway, so this brings us one small step closer to that.
|
@swift-ci test |
|
PR testing appears to be broken: |
|
@swift-ci test |
No source change here, only reorganization that was deferred to avoid making diffs hard to read.
atrick
force-pushed
the
predmem_refactor
branch
from
3199cfe to
1ceebec
Compare
|
@swift-ci test |
|
@swift-ci smoke test macosx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to add handling for mark_dependence instructions.
Extracting NFC changes to ensure that behavior of this mandatory pass does not accidentally change. It is closely coupled with several diagnostic passes.
Fully encapsulate ownership fixup so we can extend it.
PredictableMemOpt: remove non-OSSA support