Skip to content

[stdlib][android] ignore the -Wgnu-offsetof-extensions in ExecutorChe… #76841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Oct 3, 2024

…cks.cpp

ExecutorChecks.cpp no longer builds for android as -Wgnu -Werror is used for stdlib

…cks.cpp

ExecutorChecks.cpp no longer builds for android as -Wgnu -Werror is used for stdlib
@hyp hyp requested a review from compnerd October 3, 2024 00:32
@hyp hyp requested a review from ktoso as a code owner October 3, 2024 00:32
@hyp
Copy link
Contributor Author

hyp commented Oct 3, 2024

@swift-ci please test

@ktoso
Copy link
Contributor

ktoso commented Oct 3, 2024

Ok but what were the errors/warnings?

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is rather unfortunate.

@hyp
Copy link
Contributor Author

hyp commented Oct 3, 2024

@ktoso these were the warnings:

D:/r/_work/swift-build/swift-build/SourceCache/swift/stdlib/public/Concurrency/ExecutorChecks.cpp:56:52: error: using an array subscript expression within 'offsetof' is a Clang extension [-Werror,-Wgnu-offsetof-extensions]
static_assert(offsetof(swift::Job, SchedulerPrivate[0]) == offsetof(SwiftJob, schedulerPrivate[0]));
                                                   ^
D:/r/_work/swift-build/swift-build/SourceCache/swift/stdlib/public/Concurrency/ExecutorChecks.cpp:56:95: error: using an array subscript expression within 'offsetof' is a Clang extension [-Werror,-Wgnu-offsetof-extensions]
static_assert(offsetof(swift::Job, SchedulerPrivate[0]) == offsetof(SwiftJob, schedulerPrivate[0]));
                                                                                              ^
D:/r/_work/swift-build/swift-build/SourceCache/swift/stdlib/public/Concurrency/ExecutorChecks.cpp:57:52: error: using an array subscript expression within 'offsetof' is a Clang extension [-Werror,-Wgnu-offsetof-extensions]
static_assert(offsetof(swift::Job, SchedulerPrivate[1]) == offsetof(SwiftJob, schedulerPrivate[1]));
                                                   ^
D:/r/_work/swift-build/swift-build/SourceCache/swift/stdlib/public/Concurrency/ExecutorChecks.cpp:57:95: error: using an array subscript expression within 'offsetof' is a Clang extension [-Werror,-Wgnu-offsetof-extensions]
static_assert(offsetof(swift::Job, SchedulerPrivate[1]) == offsetof(SwiftJob, schedulerPrivate[1]));

@hyp
Copy link
Contributor Author

hyp commented Oct 3, 2024

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Oct 3, 2024

@compnerd could you please kick off a windows build?

@hjyamauchi
Copy link
Contributor

@swift-ci please test Windows Platform

@hyp hyp merged commit e646188 into swiftlang:main Oct 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants