Allow existential parameterized compositions: any P<A> & Q
#76705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
requested review from
hborla,
xedin,
AnthonyLatsis,
jckarter and
rjmccall
as code owners
slavapestov
force-pushed
the
existential-parameterized-composition
branch
from
5096fd8 to
4fcf025
Compare
xedin
approved these changes
Sep 25, 2024
slavapestov
force-pushed
the
existential-parameterized-composition
branch
from
4fcf025 to
c733692
Compare
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
|
This needs evolution approval, right? EDIT: no, it looks like SE-0353 meant to include this capability |
|
@slavapestov any ideas when this may be merged in? Thank you! |
slavapestov
force-pushed
the
existential-parameterized-composition
branch
from
c733692 to
4f2d69c
Compare
slavapestov
force-pushed
the
existential-parameterized-composition
branch
from
4f2d69c to
6241afa
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test |
auto-merge was automatically disabled
May 23, 2025 18:33
Pull Request is not mergeable
slavapestov
force-pushed
the
existential-parameterized-composition
branch
2 times, most recently
from
1fa9afc to
7c4564c
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We originally didn't implement support for compositions of the form
any P<A> & Q, but users discovered that we would accept this if you defined a typealias, liketypealias Alias = P<A> & Qand then wroteany Alias. However, of course this didn't alway behave correctly, hence the bug reports.Over time, I fixed most of the underlying problems that prevented this from working. The last missing piece was the ASTDemangler support for such types. Now that this is place, I think it's safe to lift this restriction.