[CSBindings] Prevent BindingSet::isViable from dropping viable bindings
#76487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings I think the original idea was to elide `Array<$T>` if there is a binding a resolved generic arguments i.e. `Array<Float>`, but the check doesn't account for the fact that bindings could be of different kinds and there are some implicit conversions that could be missed if we remove the bindings. For example, given the following constraints: `Array<$T0> conv $T1` `$T1 conv Array<(String, Int)>` `$T0` can be a supertype of `Array<$T0>` and subtype of `Array<(String, Int)>`. The solver should accept both types as viable bindings because the `$T0` could be bound to `(key: String, value: Int)` and that would match `Array<(String, Int)>` conversion.
Contributor
Author
|
@swift-ci please test |
hamishknight
approved these changes
Sep 16, 2024
Contributor
Author
|
@swift-ci please test source compatibility |
xedin
added a commit
to xedin/swift
that referenced
this pull request
Oct 21, 2024
…collection types This is follow-up to swiftlang#76487 It's reasonable to coalesce bindings of different kind if they don't allow implicit conversions like stdlib collection types do. Resolves: swiftlang#77003
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the original idea was to elide
Array<$T>if there is abinding a resolved generic arguments i.e.
Array<Float>, butthe check doesn't account for the fact that bindings could be
of different kinds and there are some implicit conversions that
could be missed if we remove the bindings.
For example, given the following constraints:
Array<$T0> conv $T1$T1 conv Array<(String, Int)>$T0can be a supertype ofArray<$T0>and subtype ofArray<(String, Int)>.The solver should accept both types as viable bindings because the
$T0could be bound to
(key: String, value: Int)and that would matchArray<(String, Int)>conversion.