[cxx-interop] Import certain types as @unsafe #76429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
ahoppen,
bnbarham,
hamishknight,
rintaro,
zoecarver,
hyp,
egorzhdan,
artemcm,
tshortli,
beccadax,
ian-twilightcoder and
DougGregor
as code owners
Xazax-hun
commented
Sep 12, 2024
DougGregor
requested changes
Sep 13, 2024
Xazax-hun
force-pushed
the
gaborh/safe-cxx-interop-mode
branch
from
b30df78 to
5b77dbd
Compare
Xazax-hun
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
DougGregor
approved these changes
Sep 13, 2024
Xazax-hun
force-pushed
the
gaborh/safe-cxx-interop-mode
branch
from
5b77dbd to
0e740f8
Compare
In this mode all C++ types are imported as unsafe by default. Users explicitly marking types are escapable or not escapable can make them imported as safe. In the future, we also want to import unannotated functions as unsafe and add more logic to infer types that are actually safe, like agregates of escapable types.
Xazax-hun
force-pushed
the
gaborh/safe-cxx-interop-mode
branch
from
0e740f8 to
929c0ca
Compare
|
@swift-ci please smoke test |
Xazax-hun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this mode all C++ types are imported as unsafe by default. Users explicitly marking types are escapable or not escapable can make them imported as safe. In the future, we also want to import unannotated functions as unsafe and add more logic to infer types that are actually safe, like aggregates of escapable types.
rdar://135876415