Use SwiftIfConfig to determine where to emit new parser diagnostics #76074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to the new `canImport` API that includes TokenSyntax nodes for each import path, so we can provide better source locations. We no longer need to stuff a random source location into `CompilerBuildConfiguration`. Make use of `ConfiguredRegions.isActive(_:)` directly instead of going through the older entrypoint. When parser validation is enabled, we currently can end up with duplicated diagnostics from canImport. This is going to require some requestification to address.
DougGregor
requested review from
ahoppen,
bnbarham,
CodaFi,
hamishknight and
rintaro
as code owners
|
@swift-ci please smoke test |
Since these duplicated diagnostics only occur under the ParserValidation testing mode, it won't affect users yet.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-establish the use of
SwiftIfConfigto determine where to emit new parser diagnostics, after it was reverted in #76040. This leverages improvements toSwiftIfConfigthat match the evaluation semantics of the compiler as well as providing better source-location information.