Skip to content

[windows] split out complex module from ucrt module, to allow new swi… #75721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 12, 2024
Merged

[windows] split out complex module from ucrt module, to allow new swi… #75721

merged 2 commits into from
Aug 12, 2024

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Aug 6, 2024

…ft-foundation to import ucrt when C++ interoperability is enabled

Fixes #75691

Also depends on a fix for:
#75720

@hyp
[windows] split out complex module from ucrt module, to allow new swi…
b62eafd 
…ft-foundation to import ucrt when C++ interoperability is enabled

Fixes swiftlang#75691
@hyp hyp requested review from a team, zoecarver and egorzhdan as code owners August 6, 2024 18:40
@hyp hyp mentioned this pull request Aug 6, 2024
Merged
@hyp hyp requested a review from compnerd August 6, 2024 18:46
@hyp
Copy link
Contributor Author

hyp commented Aug 6, 2024

Requires swiftlang/swift-foundation#830 as well.

@hyp
Copy link
Contributor Author

hyp commented Aug 6, 2024

Please test with following PRs:
swiftlang/swift-foundation#830

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Aug 6, 2024

Please test with following PRs:
swiftlang/swift-foundation#830

@swift-ci please build toolchain

compnerd
compnerd approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is complex 😂

@hyp
Copy link
Contributor Author

hyp commented Aug 7, 2024

@swift-ci please test

@compnerd
Copy link
Member

compnerd commented Aug 7, 2024

@swift-ci please test Windows platform

@hyp
Copy link
Contributor Author

hyp commented Aug 8, 2024

@swift-ci please test windows

@hyp
Copy link
Contributor Author

hyp commented Aug 8, 2024

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Aug 8, 2024

@swift-ci please build toolchain

@hyp
Copy link
Contributor Author

hyp commented Aug 8, 2024

@swift-ci please test windows

@hyp
Copy link
Contributor Author

hyp commented Aug 8, 2024

@compnerd could you do another windows test+toolchain launch please?

@compnerd
Copy link
Member

compnerd commented Aug 8, 2024

@swift-ci please test Windows platform

@hyp hyp merged commit d35af38 into swiftlang:main Aug 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@egorzhdan egorzhdan egorzhdan approved these changes

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

swift-foundation is incompatible with windows UCRT when C++ interoperability is enabled
3 participants
@hyp @compnerd @egorzhdan