[6.0] ModuleInterface: Print -target-variant flag in .swiftinterface files #75352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to ensure that availability checks contained in inlined functions are compiled correctly for zippered modules when built from interface. Resolves rdar://130094532.
tshortli
added
🍒 release cherry pick
|
@swift-ci please test |
nkcsgexi
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-target-variantflag was accidentally omitted from the compiler flags printed in.swiftinterfacefiles, causing zippered modules containing inlinableif #availablechecks and@backDeployeddeclarations to be miscompiled when compiled from interface.withValue()to manage a@TaskLocal. Without the fix, a test compiled for macCatalyst and using Swift Testing could crash unexpectedly when running on an older version of macOS. Any macCatalyst app using any@backDeployedAPI could run into similar issues, and@backDeployedwas adopted heavily in commonly used APIs.-target-variantto.swiftinterfacesis correct. However, doing so may reveal other issues since we do not have experience with libraries including this flag correctly.